Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Make stage cache kconfig selection proper
......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@244
PS17, Line 244: default !NO_RELOCATABLE_STAGES
If a platform does not support relocatable ramstage, but still wants to use stage cache to stash […]
Interesting. Did you check where the hang comes from?
https://review.coreboot.org/c/coreboot/+/33116/17/src/arch/x86/Makefile.inc
File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33116/17/src/arch/x86/Makefile.inc@...
PS17, Line 378: CONFIG_STAGE_CACHE
we should make this !NO_RELOCATABLE_RAMSTAGE ?
That might keep things clear.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 17
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jul 2019 02:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment