Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik.
SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86508?usp=email )
Change subject: mb/google/nissa/var/meliks: Add VBT data file
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
but just verified the bootimage has the VBT from chrome-internal.
I meant the bootimage without `INTEL_GMA_HAVE_VBT` has VBT in cbfs, so just wonder what is `INTEL_GMA_HAVE_VBT` for exactly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86508?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd21fbce6fdcc77ebb3d372fd7eebd7c4a2d789d
Gerrit-Change-Number: 86508
Gerrit-PatchSet: 1
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 21 Feb 2025 01:32:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com