[coreboot-gerrit] Change in coreboot[master]: amdfwtool: Take a config file instead of command line parameters

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )

Change subject: amdfwtool: Take a config file instead of command line parameters
......................................................................

Patch Set 28:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42859/28/util/amdfwtool/amdfwtool.c 
File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/42859/28/util/amdfwtool/amdfwtool.c... 
PS28, Line 1253: 		.rom_size = CONFIG_ROM_SIZE,
related to my older comment on the makefile patch: i'd just zero-initialize this and also drop the CONFIG_ROM_SIZE ifdef thing above. it seems that all makefiles that end up calling amdfwtool pass the flash size as parameter, so CONFIG_ROM_SIZE doesn't need to be known and passed in during build time. if no flash size parameter is passed to amdfwtool, it'll just fail, which is exactly what it should be doing there.
this is something for a separate patch though.