Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34531 )
Change subject: mb/purism/librem_skl: use SOC_INTEL_COMMON_BLOCK_HDA_VERB
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/34531/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34531/1//COMMIT_MSG@14
PS1, Line 14:
Could you please add the Coverity error line as a *Found-by* tag? Jacob, do you have it?
Tested how?
https://review.coreboot.org/c/coreboot/+/34531/1//COMMIT_MSG@16
PS1, Line 16: Change-Id: I2fd5363aad027f215f93964bc6a85f00fea86c88
Don’t the hooks add the Signed-off-by line to the end?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fd5363aad027f215f93964bc6a85f00fea86c88
Gerrit-Change-Number: 34531
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Comment-Date: Wed, 24 Jul 2019 10:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment