[coreboot-gerrit] Change in coreboot[master]: arch/x86: Refactor the SMBIOS type 17 write function

[Jakub Czapiga (Code Review)]

Attention is currently required from: Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Subrata Banik, Angel Pons, Rob Barnes, Patrick Rudolph, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56628 )

Change subject: arch/x86: Refactor the SMBIOS type 17 write function
......................................................................

Patch Set 24:

(3 comments)

File src/include/spd.h:

https://review.coreboot.org/c/coreboot/+/56628/comment/5a6f3a6b_337bee6e 
PS24, Line 201: SPD_UNDEFINED 0x00
I think, this should stay. Using DDR2_SPD_UNDEFINED, DDR3_SPD_UNDEFINED etc is weird to me.

File tests/lib/dimm_info_util-test.c:

https://review.coreboot.org/c/coreboot/+/56628/comment/d0309f78_2ac946d0 
PS24, Line 109: DDR2_SPD_UNDEFINED
Why not the DDR3_SPD_UNDEFINED or LPX_SPD_UNDEFINED?
I think, that SPD_UNDEFINED should stay in src/include/spd.h, and also here

https://review.coreboot.org/c/coreboot/+/56628/comment/154c6f21_e39aecdb 
PS24, Line 151: MEMORY_TYPE_DDR2, { DDR2_SPD_UDIMM, DDR2_SPD_MICRO_DIMM,
              : 				DDR2_SPD_MINI_UDIMM }, { DDR2_SPD_RDIMM, DDR2_SPD_MINI_RDIMM },
              : 				DDR2_SPD_SODIMM
Please, use named fields. It will increase readability :)