build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29494 )
Change subject: riscv: add support to select the privilege level of the payload running ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/boot.c File src/arch/riscv/boot.c:
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/boot.c@43 PS9, Line 43: void (*fn)(uintptr_t, uintptr_t) = prog_entry(prog); function definition argument 'uintptr_t' should also have an identifier name
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/boot.c@43 PS9, Line 43: void (*fn)(uintptr_t, uintptr_t) = prog_entry(prog); function definition argument 'uintptr_t' should also have an identifier name
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/boot.c@49 PS9, Line 49: void (*doit)(void *) = prog_entry(prog); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/payload.c File src/arch/riscv/payload.c:
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/payload.c@28 PS9, Line 28: uintptr_t status = read_csr(mstatus) trailing whitespace