Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34582 )
Change subject: soc/intel/common/block/uart: Update the UART PCI device reference
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/cannonlake/ua...
File src/soc/intel/cannonlake/uart.c:
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/cannonlake/ua...
PS1, Line 53: struct device *soc_uart_console_to_device(int uart_console)
Use DEVTREE_CONST here
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/common/block/...
PS1, Line 75: pci_devfn_t dev = PCI_DEV(0, PCI_SLOT(devfn), PCI_FUNC(devfn));
Should be:
dev = PCI_BDF(device);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34582
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0fe5991f3b0b9c596c3de9472e98e4091d7dd87
Gerrit-Change-Number: 34582
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 27 Jul 2019 14:24:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment