Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )
Change subject: util/ifdtool: Identify between ICH and PCH Revision ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44816/1/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44816/1/util/ifdtool/ifdtool.c@767 PS1, Line 767: if (is_platform_with_pch()) : printf("PCH Revision: %s\n", ich_chipset_names[chipset]); : else : printf("ICH Revision: %s\n", ich_chipset_names[chipset]); nit: something like printf("%s", is_platform_with_pch() ? "PCH" : "ICH"); printf(" Revision: %s\n", ich_chipset_names[chipset]);