Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32010 )
Change subject: mediatek/mt8183: enable DDR low power feature ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/32010/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32010/1//COMMIT_MSG@8 PS1, Line 8: Please describe, what the feature does. How much power is saved, and what effects are there on the performance?
https://review.coreboot.org/#/c/32010/1/src/soc/mediatek/mt8183/dramc_pi_bas... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/#/c/32010/1/src/soc/mediatek/mt8183/dramc_pi_bas... PS1, Line 306: u8 Just use int?
https://review.coreboot.org/#/c/32010/1/src/soc/mediatek/mt8183/dramc_pi_bas... PS1, Line 339: One blank line should be enough, shouldn’t it?