[coreboot-gerrit] Change in coreboot[master]: [WIP] amd/stoneyridge: Fix CAR stack location

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34883 )

Change subject: [WIP] amd/stoneyridge: Fix CAR stack location
......................................................................

Patch Set 1:

Why do code that has always worked are now marked as problem? In particular, why are globals prohibited in romstage?
That said, what would happen if an AP executed the code you introduced? Would it be easier to modify the macro AMD_ENABLE_STACK instead (though more files)? The macro already detect BSP when setting the stack.
I believe you might avoid the global issue by modifying the macro itself.