Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43176 )
Change subject: mb/google/zork: Add VBOOT_VBNV_CMOS flag ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43176/2/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/43176/2/src/mainboard/google/zork/K... PS2, Line 106: select VBOOT_VBNV_CMOS_BACKUP_TO_FLASH Did you check that VBOOT_VBNV_OFFSET does not collide with existing uses in the cmos? There are some cmos bugs in buganizer. It looks to be 0x2a below, but we're really adding 14 to the offset for 16 bytes.
So we're really using 0x38 -> 0x48.