Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43904 )
Change subject: cpu/intel/common: Fill cpu voltage in SMBIOS tables
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43904/4/src/cpu/intel/common/voltag...
File src/cpu/intel/common/voltage.c:
https://review.coreboot.org/c/coreboot/+/43904/4/src/cpu/intel/common/voltag...
PS4, Line 12: return (rdmsr(MSR_PERF_STATUS).hi & 0xffff) * 10 / 8192;
A question about this function. It seems not all intel platforms support this field(such as CPX). Not sure it is fine to select this function in SOC_INTEL_COMMON_BLOCK_CPU.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43904
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31a7efcbeede50d986a1c096a4a59a316e09f825
Gerrit-Change-Number: 43904
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 17 Sep 2020 03:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment