8 Jul
2020
8 Jul
'20
4:47 p.m.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42523 )
Change subject: soc/amd/common,picasso: Place some ENV_X86 guards ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42523/11/src/soc/amd/common/block/a... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/42523/11/src/soc/amd/common/block/a... PS11, Line 11: CONSTANT_ACPIMMIO_BASE_ADDRESS These two are redundant. How about we remove CONSTANT_ACPIMMIO_BASE_ADDRESS ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/42523
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cb1b5a90023ebc4359835be716c5e3f9451df60
Gerrit-Change-Number: 42523
Gerrit-PatchSet: 11
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Comment-Date: Wed, 08 Jul 2020 19:47:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment