Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add family 15h ......................................................................
Patch Set 4:
(12 comments)
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 1: Family 15h in Family 15h [SOCs|Processors]
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 5: Family 15h Same as above.
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 6: number numbers
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 8: models **60h-6Fh** (_Merlin Falcon_) and : **70h-7Fh** (_Stoney Ridge_). We also support 15h trinity - the agesa code is in vendorcode/amd/ Bald Eagle also looks like it's Family 15h. That uses a binary pi 00630f01 And I guess we also support carrizo to with the binary pi 00660F01, but that's roughly the same as merlin falcon.
Trinity uses the piledriver core, and bald eagle uses the steamroller core. https://en.wikipedia.org/wiki/Piledriver_(microarchitecture) https://en.wikipedia.org/wiki/Steamroller_(microarchitecture)
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 26: : Some functionalit In the binary PI release used by coreboot, some functionality...
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 27: GPIO setting and the setting of MTRRS and GPIO configurations along with setting
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 28: (though still available on most _AGESA_ Get rid of this, because who cares?
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 28: _AGESA_ wrap at 72 characters?
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 30: reasons remove "reasons"
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 31: > Isn't there a better way to format this?
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 38: may be viewed as analogous to the : Intel® Management Engine Maybe just discuss what it does instead of comparing it to the ME.
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 44: https://www.amd.com/system/files/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf We're discussing whether we can mirror the documents on a coreboot server, but until then, maybe point to archive.org?