Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 14:
Patch Set 14:
I'm not sure if I'm doing something wrong, but when I cherry-pick this patch on top of my local tree and build an image for Mandolin, the amdfw part gets significantly smaller (shrinks from 1109248 bytes without the patch to 100352 bytes with the patch), so I guess some substantial parts are missing, but I didn't get any build error
I was missing this patch https://review.coreboot.org/c/amd_blobs/+/44170 i'd move the config files out of the blobs repo, since they aren't blobs.
when building with make -j 8 i get this error: AMDFWTOOL cc1: fatal error: config.h: No such file or directory compilation terminated. util/amdfwtool/Makefile.inc:20: recipe for target 'build/util/amdfwtool/amdfwtool.o' failed make: *** [build/util/amdfwtool/amdfwtool.o] Error 1
is config.h the config.h that gets generated from the Kconfig settings? if so, that likely shouldn't be used in the util.
this doesn't happen when building with make with out the -j 8, so there is some dependency missing in the makefile.
when building an image for mandolin, the size of amdfw is now only slightly smaller than without the patch, but in the one test i ran coreboot got stuck early in ramstage after locating fsp-s and parsing the misc hob to get the silicon type.