[coreboot-gerrit] Change in coreboot[master]: soc/intel/broadwell/pch/acpi: Fix LPD0 and LPD3 methods

[Angel Pons (Code Review)]

Attention is currently required from: Patrick Rudolph.
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52519 )

Change subject: soc/intel/broadwell/pch/acpi: Fix LPD0 and LPD3 methods
......................................................................

soc/intel/broadwell/pch/acpi: Fix LPD0 and LPD3 methods

When using references to a FieldUnit, DeRefOf is not used when storing a
value into the referenced FieldUnit, only when reading its value.

Tested on out-of-tree Compal LA-A992P, Linux no longer throws errors.

Change-Id: I60c40452f8b5bdbec76264b578957396de8676ea
Signed-off-by: Angel Pons 
---
M src/soc/intel/broadwell/pch/acpi/serialio.asl
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/52519/1

diff --git a/src/soc/intel/broadwell/pch/acpi/serialio.asl b/src/soc/intel/broadwell/pch/acpi/serialio.asl
index 2bacd2b..183bca6 100644
--- a/src/soc/intel/broadwell/pch/acpi/serialio.asl
+++ b/src/soc/intel/broadwell/pch/acpi/serialio.asl
@@ -9,7 +9,7 @@
 // Arg0 - Ref to offset 0x84 of device's PCI config space
 Method (LPD0, 1, Serialized)
 {
-	DeRefOf (Arg0) &= 0xFFFFFFFC
+	Arg0 = DeRefOf (Arg0) & 0xFFFFFFFC
    Local0 = DeRefOf (Arg0) // Read back after writing

// Use Local0 to avoid iasl warning: Method Local is set but never used
@@ -20,7 +20,7 @@
 // Arg0 - Ref to offset 0x84 of device's PCI config space
 Method (LPD3, 1, Serialized)
 {
-	DeRefOf (Arg0) |= 0x3
+	Arg0 = DeRefOf (Arg0) | 0x3
    Local0 = DeRefOf (Arg0) // Read back after writing

// Use Local0 to avoid iasl warning: Method Local is set but never used