Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37995 )
Change subject: mainboard/asus/p10s-series: Initial port to ASUS P10S-I ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37995/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37995/3//COMMIT_MSG@10 PS3, Line 10: P10S-M I would not add this board until you have boot-tested it. If you're going to get your hands on one of these soon, then it's not a problem
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 3: Enable I am not sure
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 33: // CPU I would drop this comment
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 35: : Scope (_SB) { : Device (PCI0) Device (_SB.PCI0)
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 44: // Chipset specific sleep states I just dropped these with CB:37855
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/include/mainboard.h:
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 21: #endif /* _OARD_ASUS_P10S_SERIES_H */ OARD?
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/variants/p10s-i/include/variant/gpio.h:
PS3: How did you generate this?
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/variants/p10s-m/include/variant/gpio.h:
PS3: How did you generate this?