Attention is currently required from: Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75814?usp=email )
Change subject: src/soc/intel/meteorlake: disable acpi timer for xtal shutdown
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75814/comment/0a746ab8_df847c4d :
PS1, Line 7: src/
Please remove.
https://review.coreboot.org/c/coreboot/+/75814/comment/e3174e35_3a44b126 :
PS1, Line 9: need to disable for
Do you mean “needs to be disabled”?
https://review.coreboot.org/c/coreboot/+/75814/comment/e08ef734_63b85118 :
PS1, Line 12:
How did you test and verify it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75814?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b5f8f6647364d967ed96c45fe5a9d55fdc8a2c7
Gerrit-Change-Number: 75814
Gerrit-PatchSet: 1
Gerrit-Owner: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 04:39:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment