Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37272 )
Change subject: mb/google/hatch/variants/helios: DPTF solution update
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37272/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/37272/3/src/mainboard/google/hatch/...
PS3, Line 39: 44
How did we arrive to this 44C value ? Did you check with higher value compared to 44C ? Thanks.
You can refer to test report in https://partnerissuetracker.corp.google.com/issues/131272830 C#42 . We use application Octane and speed0meter to burn system . The report compare TSR3 PASSIVE set to 44C and 85C . The performance did not have huge impact .
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93930525edf4c5efb6b73bdfc8f16950754f7c9a
Gerrit-Change-Number: 37272
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Nov 2019 10:05:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment