30 Nov
2024
30 Nov
'24
11:33 a.m.
Attention is currently required from: Caveh Jalali, Forest Mittelberg, Julius Werner, Kapil Porwal, Paul Menzel, Subrata Banik.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85326?usp=email )
Change subject: google/chromeec: Add debug timestamp for host EC commands ......................................................................
Patch Set 7:
(1 comment)
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/85326/comment/35a1f31f_342dd29b?usp... : PS6, Line 287: printk(BIOS_DEBUG, "EC HOST CMD end timestamp: %llu us, Duration: %llu us, Command: 0x%x, version: 0x%x \n",
`unnecessary whitespace before a quoted newline` […]
Fixed in patchset#7
--
To view, visit https://review.coreboot.org/c/coreboot/+/85326?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8ab89830ede940d2237ad21187b137dca9689fb0
Gerrit-Change-Number: 85326
Gerrit-PatchSet: 7
Gerrit-Owner: Jayvik Desai jayvik@google.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Forest Mittelberg bmbm@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Caveh Jalali caveh@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Forest Mittelberg bmbm@google.com
Gerrit-Comment-Date: Sat, 30 Nov 2024 11:33:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com