Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43904 )
Change subject: cpu/intel/common: Fill cpu voltage in SMBIOS tables ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/43904/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/43904/3/src/arch/x86/smbios.c@754 PS3, Line 754: if (smbios_cpu_get_voltage() > 0) I don't like that this function is called twice
https://review.coreboot.org/c/coreboot/+/43904/3/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/43904/3/src/soc/intel/common/block/... PS3, Line 3: select CPU_INTEL_COMMON I don't really like that we need to select CPU_INTEL_COMMON here. Could we move the CPU_INTEL_COMMON_VOLTAGE symbol so that it doesn't depend on CPU_INTEL_COMMON?