Matt Parnell has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 )
Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port
......................................................................
Patch Set 24:
Patch Set 24:
(4 comments)
Some suggestions so that you can understand what romstage looks like better
I have not yet addressed these items, however I also can't recall the line of thought I was working on with hellsenberg in IRC, in regard to why I've not gotten it booting yet...
I'm still new to this kind of thing so suggestions are welcome.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie744cdccd3d110b4137e0b017b3f8497d23c0497
Gerrit-Change-Number: 34946
Gerrit-PatchSet: 24
Gerrit-Owner: Matt Parnell
mparnell@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Parnell
mparnell@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 28 Aug 2019 03:34:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment