Attention is currently required from: Ivy Jian.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75150?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/var/rex0: Configure I2C timing for I2C devices
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75150/comment/e75ca8d1_08da4703 :
PS4, Line 14: TEST=Build and check I2C devices timing meet spec.
nit: lets add the new actual measured timings with the changes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75150?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5421e4fe68e856bbe9f19544954a94670c895a47
Gerrit-Change-Number: 75150
Gerrit-PatchSet: 4
Gerrit-Owner: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 13:56:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment