[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Update ACPI files

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )

Change subject: soc/intel/tigerlake: Update ACPI files
......................................................................

Patch Set 11:

(3 comments)

Any reason not use the new asl syntax in arithmetics?

https://review.coreboot.org/c/coreboot/+/37781/11/src/soc/intel/tigerlake/ac... 
File src/soc/intel/tigerlake/acpi/pch_clock_ctl.asl:

https://review.coreboot.org/c/coreboot/+/37781/11/src/soc/intel/tigerlake/ac... 
PS11, Line 22: 0xFD000000
That should be a define or read from pci config space

https://review.coreboot.org/c/coreboot/+/37781/11/src/soc/intel/tigerlake/ac... 
PS11, Line 23: 0xAD
That should be a define, too

https://review.coreboot.org/c/coreboot/+/37781/11/src/soc/intel/tigerlake/ac... 
PS11, Line 134: IMGCLKOUT_4
Why is 5 missing