Attention is currently required from: Nico Huber, Furquan Shaikh. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49407 )
Change subject: soc/intel/common/gpio: Add gpio_routes_ioapic_irq function ......................................................................
Patch Set 9:
(4 comments)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/49407/comment/71282041_ed4cc442 PS9, Line 214: 120 / (sizeof(uint32_t) * BITS_PER_BYTE) + 1
DIV_ROUND_UP(120, sizeof(uint32_t) * BITS_PER_BYTE)
Done
https://review.coreboot.org/c/coreboot/+/49407/comment/8e4ce133_faa43d3a PS9, Line 218: size_t bit_offset = irq % 32;
assert(word_offset < ARRAY_SIZE(gpio_ioapic_irqs_used)) or just return after printing an error messa […]
assert is a good call, it's not an error, it's a bug.
https://review.coreboot.org/c/coreboot/+/49407/comment/e2be3b88_4d68f9a2 PS9, Line 225: size_t bit_offset = irq % 32;
assert(word_offset < ARRAY_SIZE(gpio_ioapic_irqs_used)) or just return false after printing an error […]
assert is a good call, it's not an error, it's a bug.
File src/soc/intel/common/block/include/intelblocks/gpio.h:
https://review.coreboot.org/c/coreboot/+/49407/comment/4272a3cd_fd606f59 PS9, Line 232: routed to IOAPIC
I know this is obvious from the function implementation, but should we add a comment here indicating […]
I guess to me it isn't "routed to IOAPIC" unless the DW0 register is programmed to do so 😊I could change the wording to "programmed to route through IOAPIC" instead.