Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56675 )
Change subject: soc/amd/common/block/include/acpimmio_map: drop unused GPIO bank defines ......................................................................
soc/amd/common/block/include/acpimmio_map: drop unused GPIO bank defines
The offsets of all GPIOs in the up to four regular banks are all calculated relatively to ACPIMMIO_GPIO0_BANK, so we can just drop the unused defines for ACPIMMIO_GPIO1_BANK and ACPIMMIO_GPIO2_BANK.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I832ffdca479c1f07219a23b4a7f9be69322dfe03 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56675 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/include/amdblocks/acpimmio_map.h 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio_map.h b/src/soc/amd/common/block/include/amdblocks/acpimmio_map.h index ebfc039..7081dbb 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio_map.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio_map.h @@ -119,8 +119,6 @@ #define ACPIMMIO_MISC_BANK 0x0e00 #define ACPIMMIO_DPVGA_BANK 0x1400 #define ACPIMMIO_GPIO0_BANK 0x1500 -#define ACPIMMIO_GPIO1_BANK 0x1600 -#define ACPIMMIO_GPIO2_BANK 0x1700 #define ACPIMMIO_XHCIPM_BANK 0x1c00 #define ACPIMMIO_ACDCTMR_BANK 0x1d00 #define ACPIMMIO_AOAC_BANK 0x1e00