Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48008 )
Change subject: soc/intel/skylake: Fix comment ......................................................................
soc/intel/skylake: Fix comment
mainboard_silicon_init_params() is *not* meant for configuring GPIOs. It should only be used to configure FSP options, which can not be configured elsewhere.
Change-Id: Ia92d0d173af9c67600e93b473480967304772998 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/skylake/chip.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/48008/1
diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c index 77ff78b..28cc1c1 100644 --- a/src/soc/intel/skylake/chip.c +++ b/src/soc/intel/skylake/chip.c @@ -432,7 +432,7 @@ soc_irq_settings(params); }
-/* Mainboard GPIO Configuration */ +/* Mainboard FSP Configuration */ __weak void mainboard_silicon_init_params(FSP_S_CONFIG *params) { printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);