Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )
Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43623/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43623/1//COMMIT_MSG@9 PS1, Line 9: Tested on lemp9, touchpad confirmed to use I2C HID
"confirmed to use I2C HID"? What do you mean? […]
Done
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 2: # Lock Down
move that to chipset_lockdown
Think I'll remove the comment, it is pretty self-explanatory anyways
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 220: register "generic.hid" = ""PNP0C50""
no, this is the CID, HID should be ELAN040D
This is a generic touchpad, using this generic value for both CID and HID results in not requiring any drivers in Linux or Windows.
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 225: 15
hex 0x0f
This is 15 in hex, similar to the PCI devices. I would not change it