Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37792 ) Change subject: {drivers,soc}/intel/fsp2_0: Move chipset specific logo handling to SoC ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/c/coreboot/+/37792/7/src/drivers/intel/fsp2_0/lo... File src/drivers/intel/fsp2_0/logo.c: https://review.coreboot.org/c/coreboot/+/37792/7/src/drivers/intel/fsp2_0/lo... PS7, Line 34: } This looks much like the function in fsp1_1/, aren't they identical? I also don't see anything FSP specific here (beside the Windows-API style types), so I guess it belongs into lib/. -- To view, visit https://review.coreboot.org/c/coreboot/+/37792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30c7bdc0532ff8823e06f4136f210b542385d5ce Gerrit-Change-Number: 37792 Gerrit-PatchSet: 7 Gerrit-Owner: Wim Vervoorn <wvervoorn@eltan.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn@eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 31 Dec 2019 15:42:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment