Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32075 )
Change subject: nb/intel/sandybridge: Introduce soc/iomap.h
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32075/5/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/include/soc/iomap.h:
PS5:
Please use SPDX.
Also, could we replace "soc" with "platform" please? This is not a SoC at all...
https://review.coreboot.org/c/coreboot/+/32075/5/src/northbridge/intel/sandy...
PS5, Line 27:
Missing a tab?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93aa0e78ff52e46256debd26601600a96404509f
Gerrit-Change-Number: 32075
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Apr 2020 09:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment