Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45453 )
Change subject: mb/google/dedede/var/magolor: apply DPTF setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45453/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45453/2/src/mainboard/google/dedede...
PS2, Line 44: .tdp_pl1_override = 7,
: .tdp_pl2_override = 12,
Sumeet, Are these numbers fine. I see TDP for JSL is 6W. […]
7W will be the default setting here, but DPTF can override it between 3 and 7W (see lines 65,66)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45453
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I887d494ff097a881d519a456f24578a278323051
Gerrit-Change-Number: 45453
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Sep 2020 18:41:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment