Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31890 )
Change subject: mainboard/google/kahlee: Don't use AMD's secure OS
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31890/1/src/mainboard/google/kahlee/Kconfig
File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/#/c/31890/1/src/mainboard/google/kahlee/Kconfig@...
PS1, Line 145: SCURE
Yes, this is what the variable is named. […]
This is truly the current name of the variable, I checked. That said, if we want to change it, it should be a separate patch. Personally, I would prefer PSP_SECURE_OS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabb0632eef88170dde45dea2e2e15b54b3a06f7b
Gerrit-Change-Number: 31890
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 14 Mar 2019 14:56:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment