Attention is currently required from: Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52915 )
Change subject: mb/google/guybrush: Populate PIC IRQ data
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Patchset:
PS2:
Yeah we should add them in a followup. I think it will only affect Seabios.
ok. maybe create a bug or just keep that in your local list of things to do if you have a local list for that
Patchset:
PS3:
haven't verified if those numbers are good for all sorts of device combinations, but didn't spot anything that looked obviously wrong
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52915
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d66ccd08a86a64242dbc909c57ff9685828f61f
Gerrit-Change-Number: 52915
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Thu, 06 May 2021 23:26:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment