Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34838 )
Change subject: mb/up/squared: Do RAM config based on SKU ID ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34838/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34838/9//COMMIT_MSG@8 PS9, Line 8: tested on?
https://review.coreboot.org/c/coreboot/+/34838/9/src/mainboard/up/squared/ro... File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34838/9/src/mainboard/up/squared/ro... PS9, Line 28: * - GPIO_27: 0xd8 doesn't match memory_skuid_pads
https://review.coreboot.org/c/coreboot/+/34838/9/src/mainboard/up/squared/ro... PS9, Line 31: static const uint8_t memory_skuid_pads[] = { GPIO_214, GPIO_215 }; make sure to activate 20K pull ups on those as we don't know if there are pull ups on every hardware revision.
https://review.coreboot.org/c/coreboot/+/34838/9/src/mainboard/up/squared/ro... PS9, Line 145: * GPIO27 GPIO28 Memory size same