Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43969 )
Change subject: smbios: Fix type 17 for Windows 10
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43969/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/43969/2/src/soc/intel/common/block/...
PS2, Line 72: capida
`capida` sounds strange to me. I'd call this variable `capid0_a` instead (I think sandybridge code uses that name, for instance)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43969
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc3a363cbc3d0654dafd4176c4f4af9005210f42
Gerrit-Change-Number: 43969
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 27 Jul 2020 14:36:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment