HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41012 ) Change subject: src/mainboard/{intel/google}: Include ASL for additional PCI segment ...................................................................... Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review-1
something is wrong with Jenkins, this should fail... "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Jenkins might still use an older iasl version that doesn't check for that.
We upgraded, but we explicitly disabled that warning. There has been a lot of drama about this warning though, so I don't know what's best.
No "drama". We have acpi specs, we also have https://www.kernel.org/doc/html/latest/firmware-guide/acpi/enumeration.html so using _ADR and _HID at the same time is absolutely out of specs. now, I don't know what is the best : still using out of specs code or fix wrong code ... -- To view, visit https://review.coreboot.org/c/coreboot/+/41012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3601aa4e9002334fd80fc86ced9e1df2afc739b5 Gerrit-Change-Number: 41012 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 03 May 2020 10:38:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment