Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49193 )
Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49193/comment/8e764cca_2c82754f PS1, Line 7: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block
Is there really a linter for this or is it checkpatch?
It seems it's checkpatch.pl, but what's the difference between them? It appears in https://qa.coreboot.org/job/untested-coreboot-files/lastSuccessfulBuild/arti...
That's completely personal preference, AFAICT. There are many people in the community against it.
I understand that. Even it's only a warning, it's very irritating though. Like "should it be done like this or not"?
https://review.coreboot.org/c/coreboot/+/49193/comment/ee96e3c0_be9ab7b3 PS1, Line 10: Also, put opening braces on the previous : line.
Summary doesn't account for this change.
Moved into CB:49234