Attention is currently required from: Boris Mittelberg, Caveh Jalali, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86379?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: ec/google/chromeec: Add early power off support
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/reset.c:
https://review.coreboot.org/c/coreboot/+/86379/comment/44335126_17c184d1?usp... :
PS1, Line 8: google_chromeec_do_early_poweroff();
I'm not really sure why this is a separate function now. Just get rid of that again and put the two lines from there into here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86379?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0c634d69de36fe8bdb6a61c121e321d3626ac3ff
Gerrit-Change-Number: 86379
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 00:38:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No