Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47229 )
Change subject: mb/ocp/deltalake: Configure GPIO
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG@7
PS6, Line 7: mb/ocp/deltalake: Configure GPIO
GPIOs
https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG@13
PS6, Line 13: by Intel ITP and verify the results match with the header file.
This change is hard to review. Could you split it out in two patches. First convert the existing configuration to the new syntax, with `BUILD_TIMELESS=1` verifying nothing changed, and then add the changes from the new inteltool dump?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8
Gerrit-Change-Number: 47229
Gerrit-PatchSet: 7
Gerrit-Owner: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Nov 2020 07:54:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment