Attention is currently required from: Shelley Chen, Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support ......................................................................
Patch Set 13:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/15324d10_ece7bfb7 PS13, Line 77: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/7ed6a6a4_8c80f68a PS13, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/4f27f6cf_f80eef54 PS13, Line 83: { open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/deb42010_22ab0b7b PS13, Line 204: write32(®s->gsi_periph_base_lsb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/a57eb82a_b98f7d45 PS13, Line 205: write32(®s->gsi_periph_base_msb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/d51d0b63_2e7d6491 PS13, Line 210: if (fwIep[i].offset < GSI_REG_BASE_SIZE) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/4b533d7c_d36e9eb5 PS13, Line 221: memcpy((®s->gsi_inst_ramn),(void *)fwIRam, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/697e1223_bd1741f9 PS13, Line 223: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/d20c0608_12c016a5 PS13, Line 224: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/360dd2a7_e3ee2898 PS13, Line 226: write32(®s->gsi_ee_n_scratch_0_addr,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119811): https://review.coreboot.org/c/coreboot/+/52371/comment/442551b5_9dde6753 PS13, Line 227: write32(®s->ee_n_gsi_ee_generic_cmd,0x81); space required after that ',' (ctx:VxV)