[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Assign IOAPIC IDs, GNB APIC base with FSP

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45115 )

Change subject: soc/amd/picasso: Assign IOAPIC IDs, GNB APIC base with FSP
......................................................................

Patch Set 6:
> Patch Set 3:
>
> (2 comments)
> > Patch Set 2: Code-Review+2
> >
> > (2 comments)
> >
> > I think we should also update https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/amd/common/block/... to use the new Kconfig. However, since that is common code, you would probably need a helper(soc_get_fch_ioapic_id) to obtain the FCH IOAPIC ID, with a weak default to use CONFIG_MAX_CPUS. I think that can be addressed in a separate change. Ideally, you can put it before this change so that this CL can provide the stronger implementation of soc_get_fch_ioapic_id().
>
> Ack

Marshall, are you planning to push follow-up change for this?