Attention is currently required from: Nico Huber, Sean Rhodes.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74331 )
Change subject: device: Change NO_S0IX_SUPPORT default to def_bool
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Patchset:
PS3:
It works for me with the parent of this change checked out. Just like I would expect. […]
It should not change the behaviour, since its just a short notation so that you can write:
```
bool
default n
```
as
```
def_bool n
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc824c3e06019c8922616c1cb83df95c10e285fc
Gerrit-Change-Number: 74331
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Wed, 12 Apr 2023 16:56:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Gerrit-MessageType: comment