[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/dg41wv: Inherit the subsystemid

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30470

Change subject: mb/intel/dg41wv: Inherit the subsystemid
......................................................................

mb/intel/dg41wv: Inherit the subsystemid

Don't reprogram the same subsystemid for each PCI device.

Change-Id: Ieaeef728e200bfa826c4ae25de3e8532c493c877
Signed-off-by: Arthur Heymans 
---
M src/mainboard/intel/dg41wv/devicetree.cb
1 file changed, 23 insertions(+), 46 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/30470/1

diff --git a/src/mainboard/intel/dg41wv/devicetree.cb b/src/mainboard/intel/dg41wv/devicetree.cb
index d96ad95..da91ea2 100644
--- a/src/mainboard/intel/dg41wv/devicetree.cb
+++ b/src/mainboard/intel/dg41wv/devicetree.cb
@@ -24,14 +24,10 @@
    	end
    end
    device domain 0 on		# PCI domain
-		subsystemid 0x1458 0x5000 inherit
-		device pci 0.0 on			# Host Bridge
-			subsystemid 0x8086 0x5756
-		end
+		subsystemid 0x8086 0x5756 inherit
+		device pci 0.0 on end		# Host Bridge
    	device pci 1.0 on end			# PEG
-		device pci 2.0 on			# Integrated graphics controller
-			subsystemid 0x8086 0x5756
-		end
+		device pci 2.0 on end		# Integrated graphics controller
    	chip southbridge/intel/i82801gx	# Southbridge
    		register "pirqa_routing" = "0x0b"
    		register "pirqb_routing" = "0x0b"
@@ -66,39 +62,24 @@
    		register "sata_ahci" = "0x0" # AHCI not supported on this ICH7 variant
    		register "gpe0_en" = "0x440"

-			device pci 1b.0 on		# Audio
-				subsystemid 0x8086 0x5756
+			device pci 1b.0 on end	# Audio
+			device pci 1c.0 on end	# PCIe 1
+			device pci 1c.1 on	# PCIe 2: NIC
+				device pci 00.0 on end
    		end
-			device pci 1c.0 on end		# PCIe 1
-			device pci 1c.1 on		# PCIe 2: NIC
-				device pci 00.0 on
-					subsystemid 0x8086 0x5756
-				end
-			end
-			device pci 1c.2 off end		# PCIe 3
-			device pci 1c.3 off end		# PCIe 4
-			device pci 1c.4 off end		# PCIe 5
-			device pci 1c.5 off end		# PCIe 6
-			device pci 1d.0 on		# USB
-				subsystemid 0x8086 0x5756
-			end
-			device pci 1d.1 on		# USB
-				subsystemid 0x8086 0x5756
-			end
-			device pci 1d.2 on		# USB
-				subsystemid 0x8086 0x5756
-			end
-			device pci 1d.3 on		# USB
-				subsystemid 0x8086 0x5756
-			end
-			device pci 1d.7 on		# USB
-				subsystemid 0x8086 0x5756
-			end
-			device pci 1e.0 on end		# PCI bridge
-			device pci 1e.2 off end		# AC'97 Audio Controller
-			device pci 1e.3 off end		# AC'97 Modem Controller
-			device pci 1f.0 on		# ISA bridge
-				subsystemid 0x8086 0x5756
+			device pci 1c.2 off end	# PCIe 3
+			device pci 1c.3 off end	# PCIe 4
+			device pci 1c.4 off end	# PCIe 5
+			device pci 1c.5 off end	# PCIe 6
+			device pci 1d.0 on end	# USB
+			device pci 1d.1 on end	# USB
+			device pci 1d.2 on end	# USB
+			device pci 1d.3 on end	# USB
+			device pci 1d.7 on end	# USB
+			device pci 1e.0 on end	# PCI bridge
+			device pci 1e.2 off end	# AC'97 Audio Controller
+			device pci 1e.3 off end	# AC'97 Modem Controller
+			device pci 1f.0 on	# ISA bridge
    			chip superio/winbond/w83627dhg
    				device pnp 2e.0 on		# Floppy
    					# global
@@ -155,12 +136,9 @@
    			end
    		end
    		device pci 1f.1 off end	# PATA/IDE
-			device pci 1f.2 on		# SATA
-				subsystemid 0x8086 0x5756
-			end
-			device pci 1f.3 on		# SMbus
-				subsystemid 0x8086 0x5756
-					chip drivers/i2c/ck505
+			device pci 1f.2 on end	# SATA
+			device pci 1f.3 on	# SMbus
+				chip drivers/i2c/ck505
    				register "mask" = "{ 0xff, 0xff, 0xff,
    					 0xff, 0xff, 0xff, 0xff, 0xff,
    					 0xff, 0xff, 0xff, 0xff, 0xff,
@@ -173,7 +151,6 @@
    					 0x06, 0x00, 0xea }"
    				device i2c 69 on end
    			end
-
    		end
    	end
    end