Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32448 )
Change subject: mb/google/octopus: Clear the GPI IS & IE registers
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32448/1/src/mainboard/google/octopus/mainboa...
File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/32448/1/src/mainboard/google/octopus/mainboa...
PS1, Line 74: gpi_clear_int_cfg
I prefer that too. […]
It can be done in a few ways:
1. bootblock_soc_init can make a call to gpio_clear_int_cfg() to make sure any stable interrupt configuration is cleared. That can be done on a per-SoC basis.
2. You can also do this in gpio_configure_pads to ensure that the interrupt configuration is cleared out before any pad is configured. This will apply to all SoCs using the common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b9d3bf08472219348e20b53bae470c589039fb
Gerrit-Change-Number: 32448
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 24 Apr 2019 21:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment