Attention is currently required from: Ravi Kumar Bokka. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: verify size of memchipinfo structure ......................................................................
Patch Set 2:
(4 comments)
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/f508812f_0e3c101c PS1, Line 31: mem_chip_info_size(&memchip)
Done
Ravi, seriously, _please_ stop answering "Done" to things you didn't actually do! We're losing so much productivity from all the extra review cycles caused by this and the time spent on always having to double-check your comments. Please always make sure you 1. upload the patch, 2. use the diff view to compare your uploaded patch to the previously commented version, and then 3. resolve comments after you have verified that the new patch actually addresses them (you can write comments from right within the diff view, it's very convenient).
https://review.coreboot.org/c/coreboot/+/63026/comment/20b85c84_c9eadd38 PS1, Line 51: sizeof(struct mem_chip_info)
Done
No you didn't.
https://review.coreboot.org/c/coreboot/+/63026/comment/8a7f6ea3_8b235a1a PS1, Line 55: memchip
Done
No you didn't.
https://review.coreboot.org/c/coreboot/+/63026/comment/5f435fcb_093c87aa PS1, Line 186: mem_chip_addr, sizeof(mem_chip_addr), 0);
Done
No you didn't.