Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41900 )
Change subject: drivers/usb/pci_xhci: Add a driver to generate xHCI ACPI nodes
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41900/3/src/drivers/xhci/acpi/xhci_...
File src/drivers/xhci/acpi/xhci_acpi.c:
https://review.coreboot.org/c/coreboot/+/41900/3/src/drivers/xhci/acpi/xhci_...
PS3, Line 92: counts
I added a comment, but see line 83.
Aah! You are basically using it to generate unique HS/SS names. But is that really required? If ports live under different XHC* hierarchies, can't we just allocate names XHC0.HS0, XHC0.HS1, XHC1.HS0, XHC1.HS1?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ebaef342e45923bc181ceebef882358d33f0d1
Gerrit-Change-Number: 41900
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jun 2020 22:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment