Attention is currently required from: Stefan Reinauer, Rizwan Qureshi, Meera Ravindranath, Sridhar Siricilla, Krishna P Bhat D. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48471 )
Change subject: util/ifdtool: Add an option to set top swap block size ......................................................................
Patch Set 9:
(5 comments)
File util/ifdtool/ifdtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124281): https://review.coreboot.org/c/coreboot/+/48471/comment/ff9d1307_c2b910db PS9, Line 1071: if(((platform != PLATFORM_TGL) && (*topswap_size > 1*MiB)) || ((platform != PLATFORM_ADL) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124281): https://review.coreboot.org/c/coreboot/+/48471/comment/531013ec_ca63ce84 PS9, Line 1071: if(((platform != PLATFORM_TGL) && (*topswap_size > 1*MiB)) || ((platform != PLATFORM_ADL) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124281): https://review.coreboot.org/c/coreboot/+/48471/comment/b312e078_aa2d49e6 PS9, Line 1076: else { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124281): https://review.coreboot.org/c/coreboot/+/48471/comment/33e2e357_22c946bc PS9, Line 1122: switch (platform){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124281): https://review.coreboot.org/c/coreboot/+/48471/comment/2b18bffe_980318f6 PS9, Line 1854: if (!is_valid_topswap(&new_topswap)) { suspect code indent for conditional statements (24, 40)