Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30500 )
Change subject: [WIP]arch/x86/postcar: Add x86_64 support ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/30500/8/src/arch/x86/exit_car_x86_64.S File src/arch/x86/exit_car_x86_64.S:
https://review.coreboot.org/#/c/30500/8/src/arch/x86/exit_car_x86_64.S@70 PS8, Line 70: * 0x00: Number of variable MTRRs to clear You changed last two items to size_t so they would use 8 bytes each.
https://review.coreboot.org/#/c/30500/8/src/arch/x86/exit_car_x86_64.S@84 PS8, Line 84: pop %rbx /* Number to clear, Number to set */ The comment is wrong?
https://review.coreboot.org/#/c/30500/8/src/arch/x86/exit_car_x86_64.S@100 PS8, Line 100: shr %rbx /* Number to set. */ Should this be 'pop %rbx'?