Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32336 )
Change subject: google/kukui: Get write protection status from WP GPIO ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32336/1/src/mainboard/google/kukui/chromeos.... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/#/c/32336/1/src/mainboard/google/kukui/chromeos.... PS1, Line 36: !
Looks like it's changed recently by https://review.coreboot. […]
Daisuke, the current format is indeed preferred. You're correct to point out the recent CL which corrected many discrepancies of WP GPIO and also unified them all to use get_write_protect_state() for the initial value. We are still in discussion about re-designing this table, or changing policy of which GPIOs should be saved there. This is because some of the GPIOs never need to be read again (always use the initial value) and some of them don't even need an initial value (they are re-sampled in depthcharge). If you have any good ideas here, please get in touch.