Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code ......................................................................
Patch Set 8:
(8 comments)
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 34: device pci 2.0 on end # PCIe Host Bridge
Code copied from previous owner, will check schematics.
It's a real bridge used to control the bridges. There's a second one at 3.0, both return the same device ID.
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 35: device pci 2.1 on end # No x4 PCIe slot
same
Actually mini PCIe half slot. And it's x1.
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 36: device pci 2.2 on end # Half mPCIe slo Does not exists.
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 37: device pci 2.3 on end # NC
same
Actually LAN 1
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 38: device pci 2.4 on end # RTL8111F LAN 2
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 39: device pci 3.0 on end # PCIe Host Bridge GFX, x8, slotted.
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 43: device pci 10.0 on end # USB
same
yes, xhci
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 45: device pci 12.0 on end # USB
same
Yes, EHCI